fix: validate custom function URL at registration (stored SSRF)#40
Merged
Conversation
ValidateFunc only checked that name and funcURL were non-empty. The SSRF URL check (block private/internal/metadata addresses) was applied only at evaluation time. A caller with PMS write access could register a function with FuncURL=http://169.254.169.254/... and have it stored; every later evaluation became an internal-network probe. Added utils.ValidateFunctionURL (http/https only, rejects private, loopback, link-local, and unspecified IPs; allows localhost for dev) and call it from ValidateFunc, which all stores invoke on CreateFunction. The evaluation-time check remains as defense-in-depth. Added tests. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Generated with Claude Code